fix(composition): stabilize IME preedit layout for JP input (@FosterHoulston)#7286
Closed
FosterHoulston wants to merge 2 commits intomonkeytypegame:masterfrom
Closed
fix(composition): stabilize IME preedit layout for JP input (@FosterHoulston)#7286FosterHoulston wants to merge 2 commits intomonkeytypegame:masterfrom
FosterHoulston wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
2 tasks
Member
|
Thanks for taking the time, but this is not necessary. The fix for the issue is to simply switch the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oulston)
Description
Checks
Adding/modifying Typescript code?
qs,qsaorqsrinstead of JQuery selectors.Adding quotes?
Adding a language?
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagesAdding a theme?
packages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themesAdding a layout?
packages/schemas/src/layouts.tsfrontend/static/layoutsAdding a font?
frontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCheck if any open issues are related to this PR; if so, be sure to tag them below.
Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
Closes #7256